test(librarian): add e2e test for multi-library generation#1945
Merged
jinseopkim0 merged 3 commits intomainfrom Sep 8, 2025
Merged
test(librarian): add e2e test for multi-library generation#1945jinseopkim0 merged 3 commits intomainfrom
jinseopkim0 merged 3 commits intomainfrom
Conversation
jinseopkim0
force-pushed
the
e2e-tests
branch
from
72c7d13 to
6d839a4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1945 +/- ##
==========================================
+ Coverage 81.90% 83.06% +1.16%
==========================================
Files 83 83
Lines 8813 9167 +354
==========================================
+ Hits 7218 7615 +397
+ Misses 1240 1211 -29
+ Partials 355 341 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Could you add more test cases to verify the behavior of
|
jinseopkim0
force-pushed
the
e2e-tests
branch
from
6d839a4 to
36150a3
Compare
Contributor
Author
Thanks for the comments, I've added tests for each scenario. |
Contributor
|
Could you consolidate the three test cases into a table test? Looks like the test setups are similar to each other, only the state.yaml is different. |
Consolidates the three separate e2e test functions for multi-library generation into a single table-driven test. This improves readability and maintainability by reducing code duplication.
Contributor
Author
Thanks for the comment, done. |
JoeWang1127
reviewed
Sep 8, 2025
JoeWang1127
reviewed
Sep 8, 2025
JoeWang1127
reviewed
Sep 8, 2025
JoeWang1127
reviewed
Sep 8, 2025
JoeWang1127
reviewed
Sep 8, 2025
JoeWang1127
reviewed
Sep 8, 2025
JoeWang1127
approved these changes
Sep 8, 2025
julieqiu
pushed a commit
to julieqiu/librarian
that referenced
this pull request
Sep 12, 2025
…1945) Bumps [github.com/yuin/goldmark](https://github.com/yuin/goldmark) from 1.7.10 to 1.7.11. - [Release notes](https://github.com/yuin/goldmark/releases) - [Commits](yuin/goldmark@v1.7.10...v1.7.11) --- updated-dependencies: - dependency-name: github.com/yuin/goldmark dependency-version: 1.7.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #988