ci: use '-branch' option in Cloud Builds#1914
Merged
suztomo merged 1 commit intogoogleapis:mainfrom Sep 3, 2025
Merged
Conversation
The branch option helps us to test the Librarian's generate and stage-release behavior without touching the main branch of the SDK repository. The flag has been added in googleapis#1893. Let's use the flag in the Cloud Builds YAML files. By default, "main" is passed to the variable (cl/802643045).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1914 +/- ##
==========================================
+ Coverage 81.78% 81.91% +0.13%
==========================================
Files 83 83
Lines 8735 8788 +53
==========================================
+ Hits 7144 7199 +55
+ Misses 1238 1236 -2
Partials 353 353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Now the container image is updated. It has "-branch" flag. |
meltsufin
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch option helps us to test the Librarian's generate and
stage-release behavior without touching the main branch of the SDK
repository.
The flag has been added in #1893.
Let's use the flag in the Cloud Builds YAML files.
By default, "main" is passed to the variable (cl/802643045).
I have to wait for the librarian container image update so that the CLI interprets the
-pushoption.