Skip to content

chore(librarian): log when a service config isn't found#1865

Merged
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:log-service-config-not-found
Aug 28, 2025
Merged

chore(librarian): log when a service config isn't found#1865
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:log-service-config-not-found

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Aug 28, 2025

(As requested on #1854.)

@jskeet jskeet requested a review from JoeWang1127 August 28, 2025 12:56
@jskeet jskeet requested a review from a team as a code owner August 28, 2025 12:56
@jskeet jskeet enabled auto-merge (squash) August 28, 2025 12:56
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.56%. Comparing base (f88a51a) to head (8d15f94).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1865   +/-   ##
=======================================
  Coverage   80.55%   80.56%           
=======================================
  Files          75       75           
  Lines        8194     8195    +1     
=======================================
+ Hits         6601     6602    +1     
  Misses       1237     1237           
  Partials      356      356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@JoeWang1127 JoeWang1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jskeet jskeet merged commit 4cd4ae7 into googleapis:main Aug 28, 2025
8 checks passed
@jskeet jskeet deleted the log-service-config-not-found branch August 28, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants