feat(internal/conventionalcommits): support commit override and nested commits in parsing#1776
Merged
feat(internal/conventionalcommits): support commit override and nested commits in parsing#1776
Conversation
1d9d3e9 to
14909b7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1776 +/- ##
==========================================
+ Coverage 80.33% 81.43% +1.10%
==========================================
Files 75 74 -1
Lines 7475 7999 +524
==========================================
+ Hits 6005 6514 +509
- Misses 1146 1154 +8
- Partials 324 331 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoeWang1127
previously approved these changes
Aug 19, 2025
Contributor
JoeWang1127
left a comment
There was a problem hiding this comment.
Looks good, just a suggestion.
JoeWang1127
approved these changes
Aug 20, 2025
catchyzheng
pushed a commit
that referenced
this pull request
Aug 20, 2025
…d commits in parsing (#1776) This change moves the parsing logic to a dedicated internal/conventionalcommits package and adds support for commit overrides and nested commits. - Commit Override: A BEGIN_COMMIT_OVERRIDE/END_COMMIT_OVERRIDE block can be used to replace the entire commit message with the content inside the block. - Nested Commits: BEGIN_NESTED_COMMIT/END_NESTED_COMMIT blocks allow for multiple conventional commits to be parsed from a single commit message. Note: an "isNested" field is added for requirement "nested commits information will only be used for release notes, and not for bumping semver", see #1769 refer to [go/librarian:release-please-lite](http://go/librarian:release-please-lite#heading=h.5bformyuaenc) for discussions on supported/unsupported edge case scenarios. For #1695
zhumin8
added a commit
that referenced
this pull request
Aug 20, 2025
…ommits (#1769) Add a semver package for logic to parse and increase semantic version according to https://semver.org/, then use it to derive next version from slices of conventional commits. Note: according to [go/librarian:release-command](http://goto.google.com/librarian:release-command) and [go/librarian:commits](http://goto.google.com/librarian:commits), nested commit information should only be used for release notes, and not for bumping semver. This implementation simply disregard nested commit types when determining version bumps and always do minor for them. Note: moved conventional_commits.go to a separate package in #1776. TODO: Will also rename release_please_lite.go in a separate followup PR. Additional context: [go/librarian:release-please-lite](http://goto.google.com/librarian:release-please-lite) Fixes #1696
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves the parsing logic to a dedicated internal/conventionalcommits package and adds support for commit overrides and nested commits.
Note: an "isNested" field is added for requirement "nested commits information will only be used for release notes, and not for bumping semver", see #1769
refer to go/librarian:release-please-lite for discussions on supported/unsupported edge case scenarios.
For #1695