Skip to content

test: restore len check for goimports#1710

Merged
codyoss merged 1 commit intogoogleapis:mainfrom
codyoss:fix-ci
Aug 14, 2025
Merged

test: restore len check for goimports#1710
codyoss merged 1 commit intogoogleapis:mainfrom
codyoss:fix-ci

Conversation

@codyoss
Copy link
Copy Markdown
Member

@codyoss codyoss commented Aug 13, 2025

I must have forgot to revert removing this in #1662. Currently this check is not being enforced.

Found reviewing: #1686

I must have forgot to revert removing this in googleapis#1662. Currently this
check is not being enforced.
@codyoss codyoss requested a review from JoeWang1127 August 13, 2025 16:28
@codyoss codyoss requested a review from a team as a code owner August 13, 2025 16:28
@JoeWang1127
Copy link
Copy Markdown
Contributor

Could you fix the CI?

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.49%. Comparing base (c8a858e) to head (ba751e7).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1710   +/-   ##
=======================================
  Coverage   80.49%   80.49%           
=======================================
  Files          65       65           
  Lines        6935     6935           
=======================================
  Hits         5582     5582           
  Misses       1051     1051           
  Partials      302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codyoss
Copy link
Copy Markdown
Member Author

codyoss commented Aug 14, 2025

@JoeWang1127 I just reran failed actions, it looks like we had a network hiccup here.

@codyoss codyoss enabled auto-merge (squash) August 14, 2025 13:46
@codyoss codyoss merged commit 0c92cde into googleapis:main Aug 14, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants