test: fix flaky goimports test#1662
Merged
codyoss merged 1 commit intogoogleapis:mainfrom Aug 8, 2025
Merged
Conversation
chingor13
previously approved these changes
Aug 8, 2025
We don't need to verify the output of goimports. It will return a non-zero exit code if there are diffs.
chingor13
approved these changes
Aug 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
==========================================
- Coverage 84.08% 80.28% -3.81%
==========================================
Files 54 62 +8
Lines 6144 6785 +641
==========================================
+ Hits 5166 5447 +281
- Misses 737 1039 +302
- Partials 241 299 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codyoss
added a commit
to codyoss/librarian
that referenced
this pull request
Aug 13, 2025
I must have forgot to revert removing this in googleapis#1662. Currently this check is not being enforced.
codyoss
added a commit
that referenced
this pull request
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install tools ahead of time so tests verifying output don't have extraneous module downloading output.