refactor(sidekick): move sidekick command and internal package#1562
Merged
refactor(sidekick): move sidekick command and internal package#1562
Conversation
Move `cmd/sidekick` from `internal/sidekick/cmd/sidekick` to `cmd/sidekick`. Flatten `internal/sidekick/internal/sidekick` into `internal/sidekick`, since Go's `internal` packages cannot be imported from sibling directories and all contents of that folder exist solely to support the `sidekick` package. Fixes #1536 Fixes #1548
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
- Coverage 82.61% 82.25% -0.36%
==========================================
Files 15 16 +1
Lines 1156 1161 +5
==========================================
Hits 955 955
- Misses 151 156 +5
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Aug 4, 2025
catchyzheng
pushed a commit
that referenced
this pull request
Aug 5, 2025
Move `cmd/sidekick` from `internal/sidekick/cmd/sidekick` to `cmd/sidekick`. Flatten `internal/sidekick/internal/sidekick` into `internal/sidekick`, since Go's `internal` packages cannot be imported from sibling directories and all contents of that folder exist solely to support the `sidekick` package. Fixes #1536 Fixes #1548
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
cmd/sidekickfrominternal/sidekick/cmd/sidekicktocmd/sidekick.Flatten
internal/sidekick/internal/sidekickintointernal/sidekick, since Go'sinternalpackages cannot be imported from sibling directories and all contents of that folder exist solely to support thesidekickpackage.Fixes #1536
Fixes #1548