Skip to content

fix(godoclint): update doc comment for librarian command#1559

Merged
julieqiu merged 2 commits intomainfrom
godoclint
Aug 4, 2025
Merged

fix(godoclint): update doc comment for librarian command#1559
julieqiu merged 2 commits intomainfrom
godoclint

Conversation

@julieqiu
Copy link
Copy Markdown
Member

@julieqiu julieqiu commented Aug 4, 2025

The doc comment for cmd/librarian was previously written like a package comment instead of a command comment. This was caused by a bug in godoclint, which is now fixed. Update to [email protected] and adjust the comment.

Fixes #1558

@julieqiu julieqiu requested a review from a team as a code owner August 4, 2025 00:28
@julieqiu julieqiu requested a review from quartzmo August 4, 2025 00:28
@julieqiu julieqiu enabled auto-merge (squash) August 4, 2025 00:33
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.61%. Comparing base (ab9b4cc) to head (af75d1c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
+ Coverage   82.25%   82.61%   +0.35%     
==========================================
  Files          16       15       -1     
  Lines        1161     1156       -5     
==========================================
  Hits          955      955              
+ Misses        156      151       -5     
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julieqiu julieqiu merged commit 2bdac57 into main Aug 4, 2025
9 checks passed
@julieqiu julieqiu deleted the godoclint branch August 4, 2025 17:01
catchyzheng pushed a commit that referenced this pull request Aug 5, 2025
The doc comment for cmd/librarian was previously written like a package
comment instead of a command comment. This was caused by a bug in
godoclint, which is now fixed. Update to [email protected] and adjust the
comment.

Fixes #1558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

godoclint: upgrade and pin to v0.3.0

3 participants