Skip to content

chore(internal): fix Url to URL casing#1000

Merged
codyoss merged 1 commit intogoogleapis:mainfrom
noahdietz:chore-fix-url-casing
Jul 28, 2025
Merged

chore(internal): fix Url to URL casing#1000
codyoss merged 1 commit intogoogleapis:mainfrom
noahdietz:chore-fix-url-casing

Conversation

@noahdietz
Copy link
Copy Markdown
Contributor

Just a little clean up, renaming all instances of CamelCase Url to upper case URL

Fixes #689

@noahdietz noahdietz requested a review from a team as a code owner July 25, 2025 21:11
@noahdietz noahdietz requested a review from catchyzheng July 25, 2025 21:11
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.17%. Comparing base (15c8ff2) to head (7eac0a3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/librarian/generate.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1000   +/-   ##
=======================================
  Coverage   80.17%   80.17%           
=======================================
  Files          16       16           
  Lines        1145     1145           
=======================================
  Hits          918      918           
  Misses        170      170           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noahdietz
Copy link
Copy Markdown
Contributor Author

Can't believe I snagged # 1000 with this, kind of feel bad....

@noahdietz
Copy link
Copy Markdown
Contributor Author

@zhumin8 while I am a googler and I'm in the same greater team - I don't have write access to the repo (hence the fork), so you will have to submit for me :)

@codyoss codyoss merged commit 8a4090e into googleapis:main Jul 28, 2025
7 checks passed
catchyzheng pushed a commit that referenced this pull request Jul 28, 2025
Just a little clean up, renaming all instances of CamelCase `Url` to
upper case `URL`

Fixes #689
catchyzheng added a commit that referenced this pull request Jul 28, 2025
julieqiu pushed a commit that referenced this pull request Jul 31, 2025
Just a little clean up, renaming all instances of CamelCase `Url` to
upper case `URL`

Fixes #689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

librarian: rename Url to URL

3 participants