librarian: configure should run when libraryID is not configured in state.yaml and add the entry

Missed in #898 review. runConfigureCommand() is only invoked when library is not found in state.yaml

https://github.com/googleapis/librarian/blob/10e32185114ee020512b1e9fb1448486b0e45766/internal/librarian/generate.go#L166-L175

Then this logic leads into error
https://github.com/googleapis/librarian/blob/10e32185114ee020512b1e9fb1448486b0e45766/internal/librarian/generate.go#L442-L445

Also, configure should create a LibraryState skeleton to pass down to container via configure-request.json

cc. @cuiy0006 

	configured, err := r.detectIfLibraryConfigured(ctx)
	if err != nil {
	return err
	}

	if !configured {
	if err := r.runConfigureCommand(ctx); err != nil {
	return err
	}
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

librarian: configure should run when libraryID is not configured in state.yaml and add the entry #931

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	libraryID := findLibraryIDByAPIPath(r.state, r.cfg.API)
	if libraryID == "" {
	return errors.New("bug in Librarian: Library not found during configuration, despite being found in earlier steps")
	}

librarian: configure should run when libraryID is not configured in state.yaml and add the entry #931

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions