Skip to content

librarian: -commit still tries to push to GitHub #2390

@jskeet

Description

@jskeet

If neither -commit nor -push are specified, the commitAndPush function (in command.go) correctly stops immediately.

However, if -commit is specified but not -push, it still tries to push to GitHub. It doesn't then try to create a PR, but it shouldn't even push IMO.

The documentation is somewhat ambiguous (and has a typo):

// Commit determines whether to creat a commit for the release but not create
// a pull request.

Given that the flag for "push and create a PR" is -push rather than -pr, I really wouldn't expect it to push.

Assigning to Cody to validate that this really isn't the intended behavior; someone else can then fix, of course.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions