-
Notifications
You must be signed in to change notification settings - Fork 42
librarian: SSH remotes are not well supported #2339
Copy link
Copy link
Closed
Milestone
Description
Yesterday I was trying to test the librarian release init -push command and it was failing with auth issues until a created a fresh HTTP git remote for the repo I was working in. I believe the culprit area of the code is here:
librarian/internal/gitrepo/gitrepo.go
Lines 449 to 457 in f2d1a10
| if r.gitPassword != "" { | |
| slog.Info("Authenticating with basic auth") | |
| auth = &httpAuth.BasicAuth{ | |
| // GitHub's authentication needs the username set to a non-empty value, but | |
| // it does not need to match the token | |
| Username: "cloud-sdk-librarian", | |
| Password: r.gitPassword, | |
| } | |
| } |
It would be great if we can better support SSH remotes.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels