Skip to content

librarian: SSH remotes are not well supported #2339

@codyoss

Description

@codyoss

Yesterday I was trying to test the librarian release init -push command and it was failing with auth issues until a created a fresh HTTP git remote for the repo I was working in. I believe the culprit area of the code is here:

if r.gitPassword != "" {
slog.Info("Authenticating with basic auth")
auth = &httpAuth.BasicAuth{
// GitHub's authentication needs the username set to a non-empty value, but
// it does not need to match the token
Username: "cloud-sdk-librarian",
Password: r.gitPassword,
}
}

It would be great if we can better support SSH remotes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions