-
Notifications
You must be signed in to change notification settings - Fork 42
librarian: commits are associated with the wrong package in release-init-request.json #2254
Description
In release-init-request.json, unrelated commits are being assigned to packages which have no changes.
In googleapis/google-cloud-python@2673009, how does librarian release init decide which conventional commit messages should be assigned to each package?
See a portion of the release-init-request.json file here:
{
"image": "us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest",
"libraries": [
{
"id": "google-cloud-dlp",
"version": "3.33.0",
"last_generated_commit": "b7e013ac0b9896cf89de48706221ec22212d8d0e",
"changes": [
{
"type": "fix",
"subject": "[google-cloud-eventarc] upgrade gRPC service registration func",
"body": "An update to Go gRPC Protobuf generation will change service\nregistration function signatures to use an interface instead of a\nconcrete type in generated .pb.go service files. This change should\naffect very few client library users. See release notes advisories in\nhttps://github.com/googleapis/google-cloud-go/pull/11025.",
"source_commit_hash": "26730096e491346f02af2a82138224a110485e74",
"piper_cl_number": "808289479\nSource-link:\n[googleapis/googleapis@36533b0](https://github.com/googleapis/googleapis/commit/36533b09a6b383f3c30d13c3c26092154ecf5388)",
},
There are no changes in the library google-cloud-dlp since the last release other than a .Owlbot.yaml file being deleted
See history for google-cloud-dlp here:
https://github.com/googleapis/google-cloud-python/commits/main/packages/google-cloud-dlp
To reproduce this issue run librarian release init on the main branch of https://github.com/googleapis/google-cloud-python