Skip to content

librarian(FR): Move BEGIN_COMMIT_OVERRIDE to the top of the PR description for generate #2071

@parthea

Description

@parthea

In googleapis/google-cloud-python#14418, the PR description looks like this

This pull request is generated with proto changes between
...(exclusive) and
..(inclusive).

A bunch of librarian specific stuff

Then

BEGIN_COMMIT_OVERRIDE

With nested commits within BEGIN_COMMIT_OVERRIDE and END_COMMIT_OVERRIDE.

The output of git log would be more useful if BEGIN_COMMIT_OVERRIDE and END_COMMIT_OVERRIDE , which includes the API changes, were at the top of the PR description to make it easier to folks that are reviewing commit history locally or in Github.

current

This pull request is generated with proto changes between
[googleapis/googleapis@d300b15](https://github.com/googleapis/googleapis/commit/d300b151a973ce0425ae4ad07b3de957ca31bec6)
(exclusive) and
[googleapis/googleapis@2585041](https://github.com/googleapis/googleapis/commit/2585041b27d424ed4496d163671a95a7e1af4c31)
(inclusive).

Librarian Version: not available
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest

BEGIN_COMMIT_OVERRIDE

BEGIN_NESTED_COMMIT
feat: [google-cloud-dlp] add LocationSupport,Domain,DocumentFallbackLocation
docs: minor doc revision

PiperOrigin-RevId: 804670680

Source-link: [googleapis/googleapis@2585041](https://github.com/googleapis/googleapis/commit/2585041b27d424ed4496d163671a95a7e1af4c31)
END_NESTED_COMMIT

END_COMMIT_OVERRIDE

Proposed

BEGIN_COMMIT_OVERRIDE

BEGIN_NESTED_COMMIT
feat: [google-cloud-dlp] add LocationSupport,Domain,DocumentFallbackLocation
docs: minor doc revision

PiperOrigin-RevId: 804670680

Source-link: [googleapis/googleapis@2585041](https://github.com/googleapis/googleapis/commit/2585041b27d424ed4496d163671a95a7e1af4c31)
END_NESTED_COMMIT

END_COMMIT_OVERRIDE

This pull request is generated with proto changes between
[googleapis/googleapis@d300b15](https://github.com/googleapis/googleapis/commit/d300b151a973ce0425ae4ad07b3de957ca31bec6)
(exclusive) and
[googleapis/googleapis@2585041](https://github.com/googleapis/googleapis/commit/2585041b27d424ed4496d163671a95a7e1af4c31)
(inclusive).

Librarian Version: not available
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions