Skip to content

librarian: generate reports no changes even when there are some #1963

@jskeet

Description

@jskeet

Scenario for repro:

  • Local clone of google-cloud-go
  • Check out librarian-test branch
  • Run LIBRARIAN_GITHUB_TOKEN=$(gh auth token) ../librarian-cli generate -push -branch librarian-test

Expected result: a PR with changes

Actual result: a successful run, including running the generator, but ending with "No changes to commit, skipping commit and push." But using git status there are clearly changes.

(Not sure if the branch flag is relevant here? I would expect the "is it clean" check to just use the state of the current working tree...)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions