Skip to content

librarian: generation is looking for conventional commits in the wrong repo (I believe) #1866

@jskeet

Description

@jskeet

Having just updated to the latest version of the CLI, I'm getting errors like this when generating Go libraries:

failed to fetch conventional commits for library, maps: failed to get commits for library maps: did not find commit 6914b3387f851ae8411231e4e57fefa5290eb9f8 when iterating

I believe the issue is in #1837, and I think it's for two reasons:

  • It's looking in the language repo, not the googeapis repo
  • It's looking for changes in the source roots of the library, not the source paths of the APIs

I may have misunderstood, of course.

Marking as p1 as I'd expect generation to always fail at the moment - the commit stored in state.last_generated_commit will never be in the language repo.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions