Skip to content

librarian: better support local remotes when interacting with GitHub #1751

Closed
Bug
Closed
librarian: better support local remotes when interacting with GitHub#1751
Bug
Assignees
codyoss
Milestone
Unplanned: legacylibrarian
@codyoss

Description

@codyoss
codyoss
opened on Aug 15, 2025

I noticed when writing some of the code for tag-and-realse that we don't support creating a GitHub client when the repo specified is not a URL. This can be seen here:

librarian/internal/librarian/generate.go

Lines 120 to 131 in 5a70ec1

var ghClient GitHubClient
if isURL(cfg.Repo) {
// repo is a URL
languageRepo, err := github.ParseURL(cfg.Repo)
if err != nil {
return nil, fmt.Errorf("failed to parse repo url: %w", err)
}
ghClient, err = github.NewClient(cfg.GitHubToken, languageRepo)
if err != nil {
return nil, fmt.Errorf("failed to create GitHub client: %w", err)
}
}

We should make an attempt at reading the local remotes perhaps.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Bug

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions