Skip to content

sidekick: fix golangci-lint #1541

@julieqiu

Description

@julieqiu
--- FAIL: TestGolangCILint (1.53s)
    all_test.go:156: /Users/julieqiu/bin/homebrew/Cellar/go/1.24.4/libexec/bin/go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest run: exit status 1
        internal/sidekick/internal/api/model.go:27:2: Comment should end in a period (godot)
                // descriptorpb.FieldDescriptorProto_Type
                ^
        internal/sidekick/internal/api/model.go:290:1: Comment should end in a period (godot)
        // ```
        ^
        internal/sidekick/internal/api/model.go:368:1: Comment should end in a period (godot)
        // OperationInfo contains normalized long running operation info
        ^
        internal/sidekick/internal/api/documentation.go:116:9: QF1004: could use strings.ReplaceAll instead (staticcheck)
                new := strings.Replace(*documentation, override.Match, override.Replace, -1)
                       ^
        internal/sidekick/internal/dart/annotate.go:593:3: QF1002: could use tagged switch on field.Typez (staticcheck)
                        switch {
                        ^
        internal/sidekick/internal/dart/annotate.go:613:3: QF1002: could use tagged switch on valueField.Typez (staticcheck)
                        switch {
                        ^
        internal/sidekick/internal/dart/annotate.go:669:3: QF1002: could use tagged switch on field.Typez (staticcheck)
                        switch {
                        ^
        internal/sidekick/internal/dart/annotate.go:681:3: QF1002: could use tagged switch on valueField.Typez (staticcheck)
                        switch {
                        ^
        internal/sidekick/internal/dart/annotate.go:730:3: QF1002: could use tagged switch on field.Typez (staticcheck)
                        switch {
                        ^
        internal/sidekick/internal/parser/pagination.go:63:6: QF1001: could apply De Morgan's law (staticcheck)
                        if !(hasPageSize && hasPageToken != nil) {
                           ^
        internal/sidekick/internal/parser/pagination.go:87:6: QF1001: could apply De Morgan's law (staticcheck)
                        if !(hasNextPageToken && hasRepeatedItem) {
                           ^
        internal/sidekick/internal/rust/annotate.go:775:3: QF1002: could use tagged switch on segment (staticcheck)
                        switch {
                        ^
        internal/sidekick/internal/rust/codec.go:492:2: QF1003: could use tagged switch on f.Typez (staticcheck)
                if f.Typez == api.MESSAGE_TYPE {
                ^
        internal/sidekick/sidekick_test.go:148:30: QF1004: could use strings.ReplaceAll instead (staticcheck)
                                        "package-name-override": strings.Replace(config.Name, "/", "-", -1) + "-golden-protobuf",
                                                                 ^
        internal/sidekick/downloads_cache_test.go:209:49: makeTestContents - result 1 (error) is always nil (unparam)
        func makeTestContents(t *testing.T) (*contents, error) {
                                                        ^
        internal/sidekick/internal/dart/annotate.go:202:74: (*annotateModel).annotateModel - result 0 (*github.com/googleapis/librarian/internal/sidekick/internal/dart.modelAnnotations) is never used (unparam)
        func (annotate *annotateModel) annotateModel(options map[string]string) (*modelAnnotations, error) {
                                                                                 ^
        internal/sidekick/internal/golang/gotemplate.go:106:64: annotateModel - result 0 (*github.com/googleapis/librarian/internal/sidekick/internal/golang.modelAnnotations) is never used (unparam)
        func annotateModel(model *api.API, options map[string]string) (*modelAnnotations, error) {
                                                                       ^
        internal/sidekick/downloads_cache_test.go:33:14: os.MkdirTemp() could be replaced by t.TempDir() in TestExistingDirectory (usetesting)
                tmp, err := os.MkdirTemp(t.TempDir(), "sidekick-test-")
                            ^
        internal/sidekick/downloads_cache_test.go:65:18: os.MkdirTemp() could be replaced by t.TempDir() in TestWithDownload (usetesting)
                testDir, err := os.MkdirTemp(t.TempDir(), "sidekick-test-")
                                ^
        internal/sidekick/downloads_cache_test.go:112:18: os.MkdirTemp() could be replaced by t.TempDir() in TestTargetExists (usetesting)
                testDir, err := os.MkdirTemp(t.TempDir(), "sidekick-test-")
                                ^
        internal/sidekick/downloads_cache_test.go:147:18: os.MkdirTemp() could be replaced by t.TempDir() in TestDownloadGoogleapisRootTgzExists (usetesting)
                testDir, err := os.MkdirTemp(t.TempDir(), "sidekick-test-")
                                ^
        internal/sidekick/downloads_cache_test.go:170:18: os.MkdirTemp() could be replaced by t.TempDir() in TestDownloadGoogleapisRootNeedsDownload (usetesting)
                testDir, err := os.MkdirTemp(t.TempDir(), "sidekick-test-")
                                ^
        internal/sidekick/sidekick_dart_test.go:26:17: os.MkdirTemp() could be replaced by t.TempDir() in TestDartFromProtobuf (usetesting)
                outDir, err := os.MkdirTemp(t.TempDir(), "golden")
                               ^
        internal/sidekick/sidekick_rust_prost_convert_test.go:25:17: os.MkdirTemp() could be replaced by t.TempDir() in TestRustProstConvert (usetesting)
                outDir, err := os.MkdirTemp(t.TempDir(), "golden")
                               ^
        internal/sidekick/sidekick_rust_prost_test.go:25:17: os.MkdirTemp() could be replaced by t.TempDir() in TestRustProstFromProtobuf (usetesting)
                outDir, err := os.MkdirTemp(t.TempDir(), "golden")
                               ^
        internal/sidekick/sidekick_sample_test.go:25:17: os.MkdirTemp() could be replaced by t.TempDir() in TestSampleFromProtobuf (usetesting)
                outDir, err := os.MkdirTemp(t.TempDir(), "golden")
                               ^
        internal/sidekick/sidekick_test.go:43:17: os.MkdirTemp() could be replaced by t.TempDir() in TestRustFromOpenAPI (usetesting)
                outDir, err := os.MkdirTemp(t.TempDir(), "golden")
                               ^
        internal/sidekick/sidekick_test.go:84:17: os.MkdirTemp() could be replaced by t.TempDir() in TestRustFromProtobuf (usetesting)
                outDir, err := os.MkdirTemp(t.TempDir(), "golden")
                               ^
        internal/sidekick/sidekick_test.go:176:17: os.MkdirTemp() could be replaced by t.TempDir() in TestRustModuleFromProtobuf (usetesting)
                outDir, err := os.MkdirTemp(t.TempDir(), "golden")
                               ^
        internal/sidekick/sidekick_test.go:244:17: os.MkdirTemp() could be replaced by t.TempDir() in TestRustBootstrapWkt (usetesting)
                outDir, err := os.MkdirTemp(t.TempDir(), "golden")
                               ^
        internal/sidekick/sidekick_test.go:311:17: os.MkdirTemp() could be replaced by t.TempDir() in TestRustOverrideTitleAndDescription (usetesting)
                outDir, err := os.MkdirTemp(t.TempDir(), "golden")
                               ^
        internal/sidekick/sidekick_test.go:363:17: os.MkdirTemp() could be replaced by t.TempDir() in TestGoFromProtobuf (usetesting)
                outDir, err := os.MkdirTemp(t.TempDir(), "golden")
                               ^
        internal/sidekick/update_test.go:39:8: os.Chdir() could be replaced by t.Chdir() in TestUpdateRootConfig (usetesting)
                defer os.Chdir(cwd)
                      ^
        internal/sidekick/update_test.go:40:12: os.Chdir() could be replaced by t.Chdir() in TestUpdateRootConfig (usetesting)
                if err := os.Chdir(tempDir); err != nil {
                          ^
        34 issues:
        * godot: 3
        * staticcheck: 11
        * unparam: 3
        * usetesting: 17
        exit status 1

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions