fix: show chores in release notes (#2544)

chingor13 · web-flow · commit 88b62ccb494a · 2025-10-14T10:48:48.000-07:00
Fixes #2494
diff --git a/internal/librarian/release_notes.go b/internal/librarian/release_notes.go
@@ -56,6 +56,7 @@ var (
 		"perf",
 		"revert",
 		"docs",
+		"chore",
 	}
 
 	shortSHA = func(sha string) string {
diff --git a/internal/librarian/release_notes_test.go b/internal/librarian/release_notes_test.go
@@ -1194,6 +1194,43 @@ Language Image: go:1.21
 			ghRepo:          &github.Repository{},
 			wantReleaseNote: fmt.Sprintf("Librarian Version: %s\nLanguage Image: go:1.21", librarianVersion),
 		},
+		{
+			name: "generate with chore",
+			state: &config.LibrarianState{
+				Image: "go:1.21",
+				Libraries: []*config.LibraryState{
+					{
+						ID: "my-library",
+						// this is the newVersion in the release note.
+						Version:          "1.1.0",
+						PreviousVersion:  "1.0.0",
+						ReleaseTriggered: true,
+						Changes: []*conventionalcommits.ConventionalCommit{
+							{
+								Type:       "chore",
+								Subject:    "some chore",
+								Body:       "this is the body",
+								CommitHash: hash1.String(),
+								IsNested:   true,
+							},
+						},
+					},
+				},
+			},
+			ghRepo: &github.Repository{Owner: "owner", Name: "repo"},
+			wantReleaseNote: fmt.Sprintf(`Librarian Version: %s
+Language Image: go:1.21
+<details><summary>my-library: 1.1.0</summary>
+
+## [1.1.0](https://github.com/owner/repo/compare/my-library-1.0.0...my-library-1.1.0) (%s)
+
+### Miscellaneous Chores
+
+* some chore ([1234567](https://github.com/owner/repo/commit/1234567))
+
+</details>`,
+				librarianVersion, today),
+		},
 	} {
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ var (`
`56`	`56`	`"perf",`
`57`	`57`	`"revert",`
`58`	`58`	`"docs",`
	`59`	`+ "chore",`
`59`	`60`	`}`
`60`	`61`
`61`	`62`	`shortSHA = func(sha string) string {`