Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

feat: add method to generated file#333

Closed
chingor13 wants to merge 1 commit intomasterfrom
test-touching-generated-file
Closed

feat: add method to generated file#333
chingor13 wants to merge 1 commit intomasterfrom
test-touching-generated-file

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Oct 27, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2020
@chingor13 chingor13 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2020
@chingor13 chingor13 force-pushed the test-touching-generated-file branch from 3d61668 to 86faabb Compare October 27, 2020 20:56
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Oct 27, 2020

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-trace-v1/src/main/java/com/google/devtools/cloudtrace/v1/GetTraceRequest.java

@product-auto-label product-auto-label Bot added the api: cloudtrace Issues related to the googleapis/java-trace API. label Oct 28, 2020
@chingor13 chingor13 mentioned this pull request Oct 30, 2020
Merged
@chingor13 chingor13 closed this Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

api: cloudtrace Issues related to the googleapis/java-trace API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chingor13