feat: fix signed url mismatch in BlobWriteChannel#915
Merged
JesseLovelace merged 2 commits intomasterfrom Jul 12, 2021
Merged
Conversation
product-auto-label
Bot
added
the
api: storage
google-cla
Bot
added
the
cla: yes
BenWhitehead
approved these changes
Jul 8, 2021
Collaborator
BenWhitehead
left a comment
BenWhitehead
left a comment
There was a problem hiding this comment.
ready to merge after cleaning up logging.propeties
| java.util.logging.ConsoleHandler.level = CONFIG | ||
|
|
||
| # Set up logging of HTTP requests and responses (uncomment "level" to show) | ||
| com.google.api.client.http.level = CONFIG No newline at end of file |
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.118.0](https://www.github.com/googleapis/java-storage/compare/v1.117.1...v1.118.0) (2021-07-13) ### Features * fix signed url mismatch in BlobWriteChannel ([#915](https://www.github.com/googleapis/java-storage/issues/915)) ([8b05867](https://www.github.com/googleapis/java-storage/commit/8b0586757523cfc550c62ff264eea3eebbd7f32e)) ### Bug Fixes * correct lastChunk retry logic in BlobWriteChannel ([#918](https://www.github.com/googleapis/java-storage/issues/918)) ([ab0228c](https://www.github.com/googleapis/java-storage/commit/ab0228c95df831d79f4a9c993908e5700dab5aa7)) ### Dependencies * update dependency com.google.apis:google-api-services-storage to v1-rev20210127-1.32.1 ([#910](https://www.github.com/googleapis/java-storage/issues/910)) ([2c54acc](https://www.github.com/googleapis/java-storage/commit/2c54acca0653a96773ab3606a8d97299e9fdf045)) * update kms.version to v0.90.0 ([#911](https://www.github.com/googleapis/java-storage/issues/911)) ([1050725](https://www.github.com/googleapis/java-storage/commit/1050725c91b4375340ba113568ba04538c7f52fc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use of the "x-goog-api-client" header when created a BlobWriteChannel for a signed url causes a mismatch with URLs generated outside that specific instance of the java client library, removing it makes sense for the intended usage of signed URLs.
Fixes #823