Skip to content

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Jul 2, 2024

@diegomarquezp diegomarquezp requested review from a team as code owners July 2, 2024 17:46
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Jul 2, 2024
JoeWang1127
JoeWang1127 previously approved these changes Jul 2, 2024
@JoeWang1127 JoeWang1127 dismissed their stale review July 2, 2024 18:00

adding comment

- source: "/google/storage/v2/.*-java/gapic-google-.*/src"
dest: "/owl-bot-staging/v2/gapic-google-cloud-storage-v2/src"
- source: "/google/storage/v2/google-cloud-storage-v2-java/gapic-google-cloud-storage-v2-java/src/main/java/com/google/storage/v2/gapic_metadata.json"
- source: "/google/storage/v2/.*-java/gapic-google-.*/src/main/java/com/google/storage/v2/gapic_metadata.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why gapic_metadata.json is not included by the previous entry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's from a commit back in January 2dec9d4

It makes sense that the previous entry should bring it, but it doesn't

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry means to move gapic_metadata.json from main/java to main/resources.

Looks like a library specific post processing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you. I oversaw this is a copy query into resources.

@diegomarquezp diegomarquezp merged commit 4914c19 into main Jul 2, 2024
@diegomarquezp diegomarquezp deleted the fix-hermetic-owlbot-yaml branch July 2, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants