chore: Update generation configuration at Tue Jul 2 22:52:30 UTC 2024 #2619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
product-auto-label
bot
added
size: m
|
Warning: This pull request is touching the following templated files:
|
gapic-google-cloud-storage-v2/src/main/resources/com/google/storage/v2/gapic_metadata.json
Show resolved
Hide resolved
BenWhitehead
requested changes
Jul 2, 2024
Comment on lines
+415
to
+418
| ## Transport | ||
|
|
||
| Cloud Storage uses gRPC for the transport layer. | ||
|
|
Collaborator
There was a problem hiding this comment.
This is only partially true, and is currently in preview. The default transport is JSON over HTTP. How do we exclude this from being added to the readme right now.
cloud-java-bot
changed the title
Contributor
|
We will start a new PR with the fix from #2620 |
diegomarquezp
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Jul 22, 2024
This PR adds a new optional entry "`transport`" to `generation_config.yaml`. The `transport` entry will only have effect in the postprocessing output (i.e. generated libraries will still have its transport inferred via BUILD.bazel). The main output file affected by this is `.repo-metadata.json` and its derived files (e.g. README.md). This addresses the [need to allow a custom transport for java-storage](googleapis/java-storage#2619 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Update generation configuration at Tue Jul 2 22:52:30 UTC 2024