test: remove error string matching (#861)

tritone · web-flow · commit 146a3d3edeaa · 2021-06-06T22:10:29.000-04:00
It looks like the text for this error on the backend has changed (sometimes) from "Precondition Failed" to "At least one of the pre-conditions you specified did not hold". I don't think it's really necessary to check the exact message in any case given that we do check for a code of 412, which implies a precondition failure. I added a check of the error Reason instead, which is more standardized. Fixes #853
diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageTest.java
@@ -3370,7 +3370,7 @@ public void testBlobReload() throws Exception {
       fail("StorageException was expected");
     } catch (StorageException e) {
       assertEquals(412, e.getCode());
-      assertEquals("Precondition Failed", e.getMessage());
+      assertEquals("conditionNotMet", e.getReason());
     }
 
     Blob updated = blob.reload();

Original file line number	Diff line number	Diff line change
`@@ -3370,7 +3370,7 @@ public void testBlobReload() throws Exception {`
`3370`	`3370`	`fail("StorageException was expected");`
`3371`	`3371`	`} catch (StorageException e) {`
`3372`	`3372`	`assertEquals(412, e.getCode());`
`3373`		`- assertEquals("Precondition Failed", e.getMessage());`
	`3373`	`+ assertEquals("conditionNotMet", e.getReason());`
`3374`	`3374`	`}`
`3375`	`3375`
`3376`	`3376`	`Blob updated = blob.reload();`