Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: wip testing native image support in Java Spanner JDBC #796

Closed
mpeddada1 wants to merge 8 commits into from
Closed

fix: wip testing native image support in Java Spanner JDBC #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca4e25b
fix: wip testing native image support in Java Spanner JDBC
mpeddada1 Apr 8, 2022
01d44b1
add system properties to maven-surefire
mpeddada1 Apr 9, 2022
176b1b0
add timeout
mpeddada1 Apr 9, 2022
e8aa558
fix pom
mpeddada1 Apr 9, 2022
1af1e33
move system properties to different location
mpeddada1 Apr 9, 2022
7892b89
use default setup of integration tests
mpeddada1 Apr 10, 2022
97293e3
remove groups option from surefire
mpeddada1 Apr 10, 2022
e8c7ce4
remove exclusion for testing purposes
mpeddada1 Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@
<configuration>
<exclude>com.google.cloud.spanner.IntegrationTest</exclude>
<reportNameSuffix>sponge_log</reportNameSuffix>
</configuration>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand All @@ -246,9 +246,6 @@
</goals>
<configuration>
<groups>com.google.cloud.spanner.IntegrationTest</groups>
<excludedGroups>
Copy link
Copy Markdown
Contributor Author

@mpeddada1 mpeddada1 Apr 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including ParallelIntegrationTests results in a few issues in the standard Java job:

com.google.cloud.spanner.jdbc.JdbcSqlExceptionFactory$JdbcSqlExceptionImpl: INVALID_ARGUMENT: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: [ERROR] relation "concerts" does not exist

com.google.cloud.spanner.FlakyTest,com.google.cloud.spanner.ParallelIntegrationTest
</excludedGroups>
</configuration>
</execution>
<execution>
Expand All @@ -267,6 +264,28 @@
</execution>
</executions>
</plugin>

<!-- Native tests use maven-surefire-plugin to run both integration tests and unit test-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<systemPropertyVariables>
<spanner.testenv.config.class>
com.google.cloud.spanner.GceTestEnvConfig
</spanner.testenv.config.class>
<spanner.testenv.instance>
projects/gcloud-devel/instances/spanner-testing-east1
</spanner.testenv.instance>
</systemPropertyVariables>
<forkedProcessTimeoutInSeconds>2400</forkedProcessTimeoutInSeconds>
<excludedGroups>
com.google.cloud.spanner.FlakyTest,com.google.cloud.spanner.ParallelIntegrationTest
</excludedGroups>
</configuration>
</plugin>
<!-- Native tests use maven-surefire-plugin to run both integration tests and unit test-->

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
Expand Down
4 changes: 4 additions & 0 deletions src/test/java/com/google/cloud/spanner/jdbc/it/ITJdbcConnectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@
@RunWith(JUnit4.class)
public class ITJdbcConnectTest extends ITAbstractJdbcTest {

static {
System.out.println("TESTING");
}

private String createBaseUrl() {
StringBuilder url = new StringBuilder("jdbc:cloudspanner:");
if (EmulatorSpannerHelper.isUsingEmulator()) {
Expand Down
1 change: 1 addition & 0 deletions src/test/java/com/google/cloud/spanner/jdbc/it/ITJdbcPreparedStatementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,6 +613,7 @@ public void test04_Timestamps() throws SQLException {
ps.setTimestamp(4, testTimestamp);
ps.setTimestamp(5, testTimestamp, testCalendar);
ps.setArray(6, connection.createArrayOf("INT64", new Long[] {}));
System.out.println("TIMEESTAMPS BEFORE EXECUTE STATEMENT");
ps.executeUpdate();
}

Expand Down
2 changes: 2 additions & 0 deletions src/test/java/com/google/cloud/spanner/jdbc/it/ITJdbcSqlMusicScriptTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ public static List<DialectTestParameter> data() {

@Override
public Dialect getDialect() {
System.out.println("*****DIALECT*****");
System.out.println(dialect);
return dialect.dialect;
}

Expand Down