Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

chore: correct Spanner instance reference for ITs#781

Merged
ansh0l merged 6 commits intomainfrom
correct-spanner-instance
Mar 12, 2022
Merged

chore: correct Spanner instance reference for ITs#781
ansh0l merged 6 commits intomainfrom
correct-spanner-instance

Conversation

@meltsufin
Copy link
Copy Markdown
Member

Fixes #778.

@meltsufin meltsufin requested review from a team March 9, 2022 15:18
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Mar 9, 2022
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/nightly/integration.cfg

Copy link
Copy Markdown
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ansh0l
Copy link
Copy Markdown
Contributor

ansh0l commented Mar 10, 2022

@meltsufin @Neenu1995 : I was talking to @thiagotnunes , and we are not clear on why the changes in Commit ea98b87 are needed. Can you explain why did we change the project? We think that this fix may not work again.

@Neenu1995
Copy link
Copy Markdown
Contributor

Currently our integration and samples tests are being run on multiple projects. We are trying to move all of them into one project for ease of maintenance and as part of some upcoming ci/cd changes.

@ansh0l ansh0l merged commit 25ad03b into main Mar 12, 2022
@ansh0l ansh0l deleted the correct-spanner-instance branch March 12, 2022 05:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner-jdbc API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The build failed

3 participants