Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

deps: use google-cloud-spanner-bom instead of libraries-bom#258

Merged
suztomo merged 1 commit intomasterfrom
remove_libraries_bom
Nov 6, 2020
Merged

deps: use google-cloud-spanner-bom instead of libraries-bom#258
suztomo merged 1 commit intomasterfrom
remove_libraries_bom

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Nov 6, 2020 •
edited
Loading

@olavloite, @stephaniewang526, @elharo, @chingor13

As this repository uses the shared dependencies BOM now, google-cloud-spanner-bom has the dependencies necessary to replace the libraries-bom. It's more smaller and will not cause the dependency conflicts that are irrelevant to this repository (motivation: #251 (comment)).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #252 ☕️

@suztomo suztomo requested review from a team November 6, 2020 17:11
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Nov 6, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 6, 2020 •
edited
Loading

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #258   +/-   ##
=========================================
  Coverage     71.40%   71.40%           
  Complexity     1104     1104           
=========================================
  Files            24       24           
  Lines          3396     3396           
  Branches        525      525           
=========================================
  Hits           2425     2425           
  Misses          756      756           
  Partials        215      215

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c2ff16...895a9e6. Read the comment docs.

@suztomo suztomo merged commit c9906c9 into master Nov 6, 2020
@suztomo suztomo deleted the remove_libraries_bom branch November 6, 2020 21:28
@suztomo suztomo mentioned this pull request Nov 6, 2020
Merged
@olavloite olavloite mentioned this pull request Nov 19, 2020
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Question: should google-cloud-spanner-jdbc use the Libraries BOM?

2 participants

@suztomo @elharo