This repository was archived by the owner on Apr 7, 2026. It is now read-only.
test: fail if the same token is seen twice#983
Merged
gcf-merge-on-green[bot] merged 2 commits intomasterfrom Mar 18, 2021
Merged
test: fail if the same token is seen twice#983gcf-merge-on-green[bot] merged 2 commits intomasterfrom
gcf-merge-on-green[bot] merged 2 commits intomasterfrom
Conversation
product-auto-label
Bot
added
the
api: spanner
google-cla
Bot
added
the
cla: yes
thiagotnunes
approved these changes
Mar 17, 2021
olavloite
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
============================================
- Coverage 85.11% 85.09% -0.02%
+ Complexity 2619 2616 -3
============================================
Files 154 154
Lines 14319 14319
Branches 1331 1331
============================================
- Hits 12187 12185 -2
- Misses 1567 1570 +3
+ Partials 565 564 -1
Continue to review full report at Codecov.
|
gcf-merge-on-green
Bot
removed
the
automerge
thiagotnunes
pushed a commit
that referenced
this pull request
Mar 19, 2021
The backup pagination test should fail if the same page token is returned twice by the backend, instead of fetching the same page indefinitely. Further investigation is necessary if that actually happens, as it is not something that is expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backup pagination test should fail if the same page token is returned twice by the backend, instead of fetching the same page indefinitely. Further investigation is necessary if that actually happens, as it is not something that is expected.