This repository was archived by the owner on Apr 7, 2026. It is now read-only.
cleanup: return instead of fallthrough + improve comment#844
Merged
thiagotnunes merged 1 commit intomasterfrom Feb 2, 2021
Merged
cleanup: return instead of fallthrough + improve comment#844thiagotnunes merged 1 commit intomasterfrom
thiagotnunes merged 1 commit intomasterfrom
Conversation
Return the TransactionSelector that is built instead of falling through to the end of the method. The behavior does not change by this, but it makes it easier to read and understand the code. Fixes #830
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
api: spanner
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
============================================
+ Coverage 85.04% 85.06% +0.01%
- Complexity 2585 2586 +1
============================================
Files 143 143
Lines 14145 14144 -1
Branches 1369 1369
============================================
+ Hits 12030 12031 +1
+ Misses 1542 1541 -1
+ Partials 573 572 -1
Continue to review full report at Codecov.
|
elharo
approved these changes
Feb 1, 2021
thiagotnunes
approved these changes
Feb 2, 2021
thiagotnunes
pushed a commit
that referenced
this pull request
May 6, 2021
Return the TransactionSelector that is built instead of falling through to the end of the method. The behavior does not change by this, but it makes it easier to read and understand the code. Fixes #830
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#6296 Changes: chore: regenerate API index Source-Link: googleapis/googleapis@8d5b1a3 feat(container): add support to modify kubelet pod pid limit in node system configuration feat: support spot VM feat: support Tier 1 bandwidth feat: update support for node pool labels, taints and network tags feat: add Binauthz Evaluation mode support to GKE Classic feat: add GKE Identity Service feat: add network tags to autopilot cluster feat: support enabling Confidential Nodes in the node pool feat: support node pool blue-green upgrade feat: add Location Policy API feat: support GPU timesharing feat: add managed prometheus feature PiperOrigin-RevId: 458323987 Source-Link: googleapis/googleapis@c51f2ed chore: regenerate API index Source-Link: googleapis/googleapis@7cfa071 feat: add cgroup mode to node system config feat: add support to modify kubelet pod pid limit in node system configuration feat: support Tier 1 bandwidth feat: support IPV6 Dual Stack (stack_type) feat: add Binauthz Evaluation mode support to GKE Classic feat: support GKE Cost Allocations feat: add network tags to autopilot cluster feat: add protect config audit api feat: support enabling Confidential Nodes in the node pool feat: support node pool blue-green upgrade feat: add Location Policy API feat: support GPU timesharing PiperOrigin-RevId: 458322449 Source-Link: googleapis/googleapis@61ea2e5 docs: minor formatting fixes PiperOrigin-RevId: 458309366 Source-Link: googleapis/googleapis@503fcb1 docs: clarify comment on update_time PiperOrigin-RevId: 458304215 Source-Link: googleapis/googleapis@917762b feat(assuredworkloads): ITAR June Preview Launch Committer: @Guisin PiperOrigin-RevId: 458302463 Source-Link: googleapis/googleapis@523fdaf build(video/stitcher): correct artifact name for npm PiperOrigin-RevId: 458276680 Source-Link: googleapis/googleapis@1e6c634 fix(gaming): publish v1beta LRO HTTP rules PiperOrigin-RevId: 458259504 Source-Link: googleapis/googleapis@181b856 docs(dialogflow/cx): improve comments for protos PiperOrigin-RevId: 458250124 Source-Link: googleapis/googleapis@913b9bd fix(security/privateca): publish v1beta1 LRO HTTP rules PiperOrigin-RevId: 458248734 Source-Link: googleapis/googleapis@e63fcd7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return the TransactionSelector that is built instead of falling through to the end of the method. The behavior does not change by this, but it makes it easier to read and understand the code.
Fixes #830