This repository was archived by the owner on Apr 7, 2026. It is now read-only.
test: test stream retries in combination with inlined begin#670
Merged
thiagotnunes merged 1 commit intomasterfrom Nov 24, 2020
Merged
test: test stream retries in combination with inlined begin#670thiagotnunes merged 1 commit intomasterfrom
thiagotnunes merged 1 commit intomasterfrom
Conversation
Adds an additional test case for inlined begin transaction when the first statement is a query. Queries are executed using executeStreamingSql, and if the stream is broken, the original RPC is retried with a resume code. That retry should not include a BeginTransaction option when the transaction has already been initialized by the first RPC.
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
api: spanner
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
============================================
+ Coverage 84.06% 84.07% +0.01%
Complexity 2497 2497
============================================
Files 141 141
Lines 13812 13812
Branches 1317 1317
============================================
+ Hits 11611 11613 +2
+ Misses 1655 1654 -1
+ Partials 546 545 -1
Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Nov 24, 2020
thiagotnunes
pushed a commit
that referenced
this pull request
May 6, 2021
Adds an additional test case for inlined begin transaction when the first statement is a query. Queries are executed using executeStreamingSql, and if the stream is broken, the original RPC is retried with a resume code. That retry should not include a BeginTransaction option when the transaction has already been initialized by the first RPC.
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#4725 Changes: chore: regenerate API index Source-Link: googleapis/googleapis@5d91687 feat(osconfig): add OSConfigZonalService API Committer: @jaiminsh PiperOrigin-RevId: 394704298 Source-Link: googleapis/googleapis@31d2d34 feat(asset): Release of relationships in v1, Add content type Relationship to support relationship search Committer: yuwangyw@ PiperOrigin-RevId: 394579113 Source-Link: googleapis/googleapis@9c7eb1f chore: Update orchestration/airflow BUILD.bazel files for nodejs PiperOrigin-RevId: 394536640 Source-Link: googleapis/googleapis@8bc0991 docs: clarified some LRO types PiperOrigin-RevId: 394490143 Source-Link: googleapis/googleapis@e3c419f chore: adjust namespacing and package name for Metrics Scopes API Committer: @busunkim96 PiperOrigin-RevId: 394470104 Source-Link: googleapis/googleapis@52c8913 chore(ruby): Populate Ruby microgenerator arguments for GkeHub V1 and V1beta PiperOrigin-RevId: 394321534 Source-Link: googleapis/googleapis@f47c388 docs(bigquery/storage): Align session length with public documentation feat: Align ReadRows timeout with other versions of the API. Committer: @emkornfield PiperOrigin-RevId: 394308710 Source-Link: googleapis/googleapis@1549a69 docs(dialogflow): clarified some LRO types PiperOrigin-RevId: 394302922 Source-Link: googleapis/googleapis@cd16abb chore: regenerate API index Source-Link: googleapis/googleapis@b7537df feat: add `CheckCompatibility` method to the API feat: add `DimensionCompatibility`, `MetricCompatibility`, `Compatibility` types to the API feat: add `category` field to `DimensionMetadata`, `MetricMetadata` types PiperOrigin-RevId: 394292123 Source-Link: googleapis/googleapis@3c414af chore: regenerate API index Source-Link: googleapis/googleapis@1c01db6 feat(bigquery/reservation): Deprecated SearchAssignments in favor of SearchAllAssignments feat: Reservation objects now contain a creation time and an update time feat: Added commitment_start_time to capacity commitments feat: Force deleting capacity commitments is allowed while reservations with active assignments exist feat: ML_EXTERNAL job type is supported feat: Optional id can be passed into CreateCapacityCommitment and CreateAssignment docs: Clarified docs for None assignments fix!: Fixed pattern for BiReservation object BREAKING_CHANGE: Changed from `bireservation` to `biReservation` PiperOrigin-RevId: 394129271 Source-Link: googleapis/googleapis@2c7f233
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an additional test case for inlined begin transaction when the first statement is a query. Queries are executed using executeStreamingSql, and if the stream is broken, the original RPC is retried with a resume code. That retry should not include a BeginTransaction option when the transaction has already been initialized by the first RPC.