Skip to content

Conversation

@surbhigarg92
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 2, 2025
@surbhigarg92 surbhigarg92 marked this pull request as ready for review December 2, 2025 07:29
@surbhigarg92 surbhigarg92 requested review from a team as code owners December 2, 2025 07:29
@rahul2393
Copy link
Contributor

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces tracing for AFE latency by adding an afe_latency attribute to spans. To support this, the logic for processing server-timing headers in HeaderInterceptor has been significantly refactored. The new structure is much cleaner, separating metric recording by system (OpenCensus, Built-in Metrics, Span Attributes), which improves readability and maintainability. The use of Float for latency values also gracefully handles cases where headers are missing. The corresponding test changes are appropriate. Overall, this is a great improvement.

@surbhigarg92 surbhigarg92 merged commit 17962e3 into main Dec 3, 2025
41 of 42 checks passed
@surbhigarg92 surbhigarg92 deleted the afe_latency_span branch December 3, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants