This repository was archived by the owner on Apr 7, 2026. It is now read-only.
chore: Add afe_latency span timing#4247
Merged
surbhigarg92 merged 2 commits intomainfrom Dec 3, 2025
Merged
Conversation
product-auto-label
Bot
added
size: m
surbhigarg92
force-pushed
the
afe_latency_span
branch
from
75db2a3 to
80982aa
Compare
Contributor
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces tracing for AFE latency by adding an afe_latency attribute to spans. To support this, the logic for processing server-timing headers in HeaderInterceptor has been significantly refactored. The new structure is much cleaner, separating metric recording by system (OpenCensus, Built-in Metrics, Span Attributes), which improves readability and maintainability. The use of Float for latency values also gracefully handles cases where headers are missing. The corresponding test changes are appropriate. Overall, this is a great improvement.
rahul2393
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.