This repository was archived by the owner on Apr 7, 2026. It is now read-only.
chore: fallback for Partitioned Operations with multiplexed session#3710
Merged
pratickchokhani merged 6 commits intogoogleapis:mainfrom Mar 27, 2025
Merged
Conversation
…tiplexed session. If PartitionQueryRequest or PartitionReadRequest with multiplexed session return unimplemented error, then an implicit fallback to regular session will occur.
product-auto-label
Bot
added
size: l
…ultiplexed-session-fallback
olavloite
changed the title
olavloite
approved these changes
Mar 26, 2025
Collaborator
olavloite
left a comment
olavloite
left a comment
There was a problem hiding this comment.
LGTM, with some minor nits
| } | ||
|
|
||
| void maybeMarkUnimplementedForPartitionedOps(SpannerException spannerException) { | ||
| boolean maybeMarkUnimplementedForPartitionedOps(SpannerException spannerException) { |
Collaborator
There was a problem hiding this comment.
I think that we should mark this entire method as synchronized. In theory, the partitionRead and partitionQuery methods could be executed in parallel, and if an UNIMPLEMENTED error is returned, we would only want to create the fallback transaction once.
Contributor
Author
There was a problem hiding this comment.
Right. Have synchronized on session.
Comment on lines
+338
to
+340
| session.setFallbackSessionReference(sessionClient.createSession().getSessionReference()); | ||
| sessionName = session.getName(); | ||
| initFallbackTransaction(); |
Collaborator
There was a problem hiding this comment.
This should only be executed if it had not already been executed (see also the comment above on making the method synchronized)
Contributor
Author
There was a problem hiding this comment.
Right. Added a validation of unimplementedForPartitionedOps before executing fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If PartitionQueryRequest or PartitionReadRequest with multiplexed session return unimplemented error, then an implicit fallback to regular session will occur.