Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

chore: Update generation configuration at Wed Oct 2 02:24:35 UTC 2024#3353

Merged
olavloite merged 5 commits intomainfrom
generate-libraries-main
Oct 2, 2024
Merged

chore: Update generation configuration at Wed Oct 2 02:24:35 UTC 2024#3353
olavloite merged 5 commits intomainfrom
generate-libraries-main

Conversation

@cloud-java-bot
Copy link
Copy Markdown
Collaborator

@cloud-java-bot cloud-java-bot commented Sep 28, 2024 •
edited
Loading

This pull request is generated with proto changes between googleapis/googleapis@005df46 (exclusive) and googleapis/googleapis@16a1580 (inclusive).

BEGIN_COMMIT_OVERRIDE
BEGIN_NESTED_COMMIT
docs: update comment for PROFILE QueryMode
feat: add new QueryMode enum values (WITH_STATS, WITH_PLAN_AND_STATS)

PiperOrigin-RevId: 680628448

Source Link: googleapis/googleapis@72a5151
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add INTERVAL API

PiperOrigin-RevId: 680405503

Source Link: googleapis/googleapis@2c9fb37
END_NESTED_COMMIT
END_COMMIT_OVERRIDE

@cloud-java-bot cloud-java-bot requested review from a team September 28, 2024 02:23
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Sep 28, 2024
@harshachinta
Copy link
Copy Markdown
Contributor

harshachinta commented Sep 30, 2024

@JoeWang1127
There are new protos published for spanner and the autogeneration created PRs in other languages (ex: Python - googleapis/python-spanner#1209 (comment))
However we don't see the PR generated for Java with this commit.
Tagging you since there were some recent changes made to autogeneration in Java. Can you please help here or point to right people?

@cloud-java-bot cloud-java-bot changed the title chore: Update generation configuration at Sat Sep 28 02:23:38 UTC 2024 chore: Update generation configuration at Mon Sep 30 20:28:50 UTC 2024 Sep 30, 2024
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Sep 30, 2024

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/ExecuteSqlRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/SpannerProto.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/StructType.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/StructTypeOrBuilder.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/Type.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/TypeCode.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/TypeOrBuilder.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/TypeProto.java
  • proto-google-cloud-spanner-v1/src/main/proto/google/spanner/v1/spanner.proto
  • proto-google-cloud-spanner-v1/src/main/proto/google/spanner/v1/type.proto

@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Sep 30, 2024
@lqiu96
Copy link
Copy Markdown
Member

lqiu96 commented Sep 30, 2024

@JoeWang1127 There are new protos published for spanner and the autogeneration created PRs in other languages (ex: Python - googleapis/python-spanner#1209 (comment)) However we don't see the PR generated for Java with this commit. Tagging you since there were some recent changes made to autogeneration in Java. Can you please help here or point to right people?

I believe the update generation job runs nightly (I believe ~10pm EST?). The config was referencing and older commitish in googleapis and it didn't have the change yet. You can manually re-run the job (https://github.com/googleapis/java-spanner/actions/workflows/update_generation_config.yaml) if you want to see if faster. I went ahead to generate it and you should see it in the PR now.

@cloud-java-bot cloud-java-bot changed the title chore: Update generation configuration at Mon Sep 30 20:28:50 UTC 2024 chore: Update generation configuration at Tue Oct 1 02:28:18 UTC 2024 Oct 1, 2024
@harshachinta
Copy link
Copy Markdown
Contributor

harshachinta commented Oct 1, 2024

Thanks @lqiu96 for helping out with this.

@harshachinta harshachinta reopened this Oct 1, 2024
@cloud-java-bot cloud-java-bot changed the title chore: Update generation configuration at Tue Oct 1 02:28:18 UTC 2024 chore: Update generation configuration at Wed Oct 2 02:24:35 UTC 2024 Oct 2, 2024
@olavloite olavloite merged commit c078ac3 into main Oct 2, 2024
@olavloite olavloite deleted the generate-libraries-main branch October 2, 2024 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rahul2393 rahul2393 rahul2393 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cloud-java-bot @harshachinta @lqiu96 @rahul2393 @olavloite