This repository was archived by the owner on Apr 7, 2026. It is now read-only.
chore(samples): add sample for spanner editions#3304
Merged
gcf-merge-on-green[bot] merged 4 commits intomainfrom Sep 16, 2024
Merged
chore(samples): add sample for spanner editions#3304gcf-merge-on-green[bot] merged 4 commits intomainfrom
gcf-merge-on-green[bot] merged 4 commits intomainfrom
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
Bot
added
size: l
rahul2393
changed the title
nithinsujir
approved these changes
Sep 3, 2024
Contributor
nithinsujir
left a comment
nithinsujir
left a comment
There was a problem hiding this comment.
Edition sample change lgtm. (There are other unrelated changes which I've not reviewed)
rahul2393
force-pushed
the
spanner-editions-sample
branch
from
ac59e86 to
0be0306
Compare
Contributor
Author
|
Other changes are mostly related to running mvn:format |
harshachinta
approved these changes
Sep 16, 2024
rahul2393
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
lqiu96
pushed a commit
that referenced
this pull request
Sep 19, 2024
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-spanner/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.