Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

chore: Composite Tracer#3163

Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
surbhigarg92:compositeTracer
Jun 18, 2024
Merged

chore: Composite Tracer#3163
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:mainfrom
surbhigarg92:compositeTracer

Conversation

@surbhigarg92
Copy link
Copy Markdown
Contributor

No description provided.

@surbhigarg92 surbhigarg92 requested a review from a team June 18, 2024 10:20
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 18, 2024
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team June 18, 2024 11:15
}
}

public void addAttributes(String key, String value) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where/when is this method called? It does not override any methods (at least it is not marked as such), and I can't find anything in this PR that seems to call it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be required for MetricsTracer

Added in advance

@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 18, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
@gcf-merge-on-green gcf-merge-on-green Bot merged commit e00b884 into googleapis:main Jun 18, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 18, 2024
@surbhigarg92 surbhigarg92 deleted the compositeTracer branch June 18, 2024 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants