Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

chore: use gson Java version util#3085

Merged
gcf-merge-on-green[bot] merged 2 commits intomainfrom
use-gson-java-version-checker
May 3, 2024
Merged

chore: use gson Java version util#3085
gcf-merge-on-green[bot] merged 2 commits intomainfrom
use-gson-java-version-checker

Conversation

@olavloite
Copy link
Copy Markdown
Collaborator

Uses the gson Java version checker, which is more production-hardened than the custom one in the Spanner client. It seems that the Spanner implementation does not get it right on all versions on Windows.

@olavloite olavloite requested a review from a team May 3, 2024 08:12
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels May 3, 2024
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2024
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 86481b5 into main May 3, 2024
@gcf-merge-on-green gcf-merge-on-green Bot deleted the use-gson-java-version-checker branch May 3, 2024 09:08
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants