This repository was archived by the owner on Apr 7, 2026. It is now read-only.
chore: add flag to force-disable multiplexed sessions#3083
Merged
Conversation
Adds an environment variable that can be used to force-disable the use of multiplexed sessions.
product-auto-label
Bot
added
size: m
rahul2393
approved these changes
May 3, 2024
rahul2393
reviewed
May 3, 2024
| this.useMultiplexedSession = | ||
| builder.useMultiplexedSession | ||
| && !Boolean.parseBoolean( | ||
| System.getenv("GOOGLE_CLOUD_SPANNER_FORCE_DISABLE_MULTIPLEXED_SESSIONS")); |
Contributor
There was a problem hiding this comment.
In this case are we expecting customers to set this env to disable multiplexed sessions, if yes then why not customers just set useMultiplexedSession=false in Spanner.Options?
Collaborator
Author
There was a problem hiding this comment.
We want an escape that they can very quickly set with zero code changes in case of calamities.
Contributor
There was a problem hiding this comment.
ok so bare minimum one need to restart the application after the env changes to disable multiplexed session.
Thanks for clarification. we need to make sure the same env is used in other languages as fail safe.
arpan14
approved these changes
May 3, 2024
olavloite
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an environment variable that can be used to force-disable the use of multiplexed sessions.