Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

chore: adding a benchmark utility in client.#3068

Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
arpan14:benchmark-util-pr
Apr 29, 2024
Merged

chore: adding a benchmark utility in client.#3068
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
arpan14:benchmark-util-pr

Conversation

@arpan14
Copy link
Copy Markdown
Contributor

@arpan14 arpan14 commented Apr 29, 2024 •
edited
Loading

  • The existing setup using JMH produces flaky results at time due to thread safe scope variables and also it lacks the ability to pass different parameters from command-line.
  • This is a more light-weight setup which allows to pass params from command-line and keeps the setup much simpler.
  • This util also allows us to export metrics/traces directly to cloud monitoring so that its easy to visualize and compare stats.

@arpan14 arpan14 requested review from a team April 29, 2024 05:52
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Apr 29, 2024
@arpan14 arpan14 requested a review from harshachinta April 29, 2024 05:52
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 29, 2024
@arpan14 arpan14 force-pushed the benchmark-util-pr branch 2 times, most recently from bf39376 to 62bc061 Compare April 29, 2024 06:26
@arpan14 arpan14 force-pushed the benchmark-util-pr branch from 62bc061 to 5c8d72d Compare April 29, 2024 06:39
harshachinta
harshachinta reviewed Apr 29, 2024
View reviewed changes
Comment thread benchmarks/README.md Outdated
harshachinta
harshachinta reviewed Apr 29, 2024
View reviewed changes
Comment thread benchmarks/README.md Outdated
@arpan14 arpan14 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 29, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 29, 2024
@gcf-merge-on-green gcf-merge-on-green Bot merged commit eb62572 into googleapis:main Apr 29, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2024
@arpan14 arpan14 deleted the benchmark-util-pr branch April 29, 2024 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@harshachinta harshachinta harshachinta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arpan14 @harshachinta