Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

chore: remove tag restrictions in Connection API#2970

Merged
olavloite merged 1 commit intomainfrom
remove-tag-restrictions
Mar 26, 2024
Merged

chore: remove tag restrictions in Connection API#2970
olavloite merged 1 commit intomainfrom
remove-tag-restrictions

Conversation

@olavloite
Copy link
Copy Markdown
Collaborator

The Connection API used a regex to limit the possible values that could be set for statement and transaction tags. These limitations were not in sync with what the actual allowed values for tags are in Spanner. The restrictions in the Connection API have therefore been removed, and all validation is done by the Spanner backend instead.

The Connection API used a regex to limit the possible values that could
be set for statement and transaction tags. These limitations were not in
sync with what the actual allowed values for tags are in Spanner. The
restrictions in the Connection API have therefore been removed, and all
validation is done by the Spanner backend instead.
@olavloite olavloite requested review from a team March 25, 2024 15:17
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 25, 2024
@olavloite olavloite merged commit a23d89f into main Mar 26, 2024
@olavloite olavloite deleted the remove-tag-restrictions branch March 26, 2024 12:17
arpan14 pushed a commit to arpan14/java-spanner that referenced this pull request Apr 1, 2024
The Connection API used a regex to limit the possible values that could
be set for statement and transaction tags. These limitations were not in
sync with what the actual allowed values for tags are in Spanner. The
restrictions in the Connection API have therefore been removed, and all
validation is done by the Spanner backend instead.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants