Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

fix: update session's last used time field for each RPC executed in transaction context.#2684

Closed
arpan14 wants to merge 5 commits intogoogleapis:mainfrom
arpan14:session-time-bug
Closed

fix: update session's last used time field for each RPC executed in transaction context.#2684
arpan14 wants to merge 5 commits intogoogleapis:mainfrom
arpan14:session-time-bug

Conversation

@arpan14
Copy link
Copy Markdown
Contributor

@arpan14 arpan14 commented Oct 17, 2023

  • Fix for issue - Session lastUseTime parameter not updated correctly for a Transaction #2659
  • Partially fixes the issue when we use TransactionManager manager = client.transactionManager() and then execute TransactionContext transaction = manager.begin(). But it does not fix yet for when we chain transactions using TransactionRunner runner = client.readWriteTransaction(); and run via runner.run()

@arpan14 arpan14 requested a review from a team October 17, 2023 09:00
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Oct 17, 2023
@arpan14
Copy link
Copy Markdown
Contributor Author

arpan14 commented Oct 27, 2023

Given this approach does not fix use-case of TransactionRunner runner = client.readWriteTransaction() and it will require a heavy refactoring if we go by this route, I am closing this PR to explore some alternate path.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant