This repository was archived by the owner on Apr 7, 2026. It is now read-only.
test: swap expected and actual values in DML returning tests.#2663
Merged
arpan14 merged 2 commits intogoogleapis:mainfrom Oct 9, 2023
Merged
test: swap expected and actual values in DML returning tests.#2663arpan14 merged 2 commits intogoogleapis:mainfrom
arpan14 merged 2 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: m
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging flaky issue - #2629 , it was noticed that
ITDmlReturningTestis not using the right convention forassertEqualsmethod. This PR swaps the value so that debugging readability is improved.For ex - The following error message in the above issue is confusing due to this swap between expected/actual values.