Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

samples: Bit Reversed Sequence support#2559

Merged
gcf-merge-on-green[bot] merged 9 commits intomainfrom
bit-rev-seq
Aug 2, 2023
Merged

samples: Bit Reversed Sequence support#2559
gcf-merge-on-green[bot] merged 9 commits intomainfrom
bit-rev-seq

Conversation

@rajatbhatta
Copy link
Copy Markdown
Contributor

@rajatbhatta rajatbhatta commented Jul 31, 2023

No description provided.

@rajatbhatta rajatbhatta requested a review from a team July 31, 2023 18:24
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jul 31, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Jul 31, 2023
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team July 31, 2023 18:26
@rajatbhatta rajatbhatta marked this pull request as draft July 31, 2023 18:29
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 31, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 31, 2023
@rajatbhatta rajatbhatta marked this pull request as ready for review July 31, 2023 18:40
@rajatbhatta rajatbhatta requested a review from arpan14 July 31, 2023 18:53
arpan14
arpan14 reviewed Aug 2, 2023
View reviewed changes
Comment thread samples/snippets/src/test/java/com/example/spanner/SequenceSampleIT.java

/** Integration tests for DML Returning samples for GoogleStandardSql dialect. */
@RunWith(JUnit4.class)
public class SequenceSampleIT extends SampleTestBase {
Copy link
Copy Markdown
Contributor

@arpan14 arpan14 Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not too much effort, can we have a single integration test and parameterise it for PG/Google SQL dialects. If no, can you add what are the differences in the way both dialects are tested?

Copy link
Copy Markdown
Contributor Author

@rajatbhatta rajatbhatta Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I've now parameterized the tests. Please take a look.

rajatbhatta and others added 6 commits August 2, 2023 18:14
@rajatbhatta
paramaterize GoogleSql and PostgreSql tests
8d1a8c6
@rajatbhatta
remove print
3c5967b
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
a74f2dc 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'bit-rev-seq' of https://github.com/googleapis/java-spanner
016dcbb 
 into bit-rev-seq
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
e4bf5b3 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'bit-rev-seq' of https://github.com/googleapis/java-spanner
d8aa9ba 
 into bit-rev-seq
@rajatbhatta rajatbhatta added the automerge Merge the pull request once unit tests and other checks pass. label Aug 2, 2023
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 7468a14 into main Aug 2, 2023
@gcf-merge-on-green gcf-merge-on-green Bot deleted the bit-rev-seq branch August 2, 2023 19:16
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@arpan14 arpan14 arpan14 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

Labels

api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rajatbhatta @arpan14 @averikitsch