Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

samples: add support for updateDatabase in Cloud Spanner#2346

Merged
gcf-merge-on-green[bot] merged 12 commits intogoogleapis:mainfrom
aayushimalik:drop-database-protection-samples
May 16, 2023
Merged

samples: add support for updateDatabase in Cloud Spanner#2346
gcf-merge-on-green[bot] merged 12 commits intogoogleapis:mainfrom
aayushimalik:drop-database-protection-samples

Conversation

@aayushimalik
Copy link
Copy Markdown
Contributor

@aayushimalik aayushimalik commented Mar 24, 2023

No description provided.

@aayushimalik aayushimalik requested a review from a team March 24, 2023 09:02
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Mar 24, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Mar 24, 2023
rajatbhatta
rajatbhatta reviewed Apr 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aayushimalik: Could you please use the sample shared internally in the client spec doc to write this sample? It is to maintain consistency in the sample across clients.

Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseDropProtectoinSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseDropProtectoinSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseDropProtectoinSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseDropProtectoinSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseDropProtectoinSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseDropProtectoinSample.java Outdated
rajatbhatta
rajatbhatta reviewed Apr 4, 2023
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseSample.java Outdated
Comment thread samples/snippets/src/test/java/com/example/spanner/UpdateDatabaseSampleIT.java Outdated
Comment thread samples/snippets/src/test/java/com/example/spanner/UpdateDatabaseSampleIT.java Outdated
@rajatbhatta rajatbhatta changed the title feat: drop database protection sample and sample test samples: add support for updateDatabase in Cloud Spanner Apr 4, 2023
rajatbhatta
rajatbhatta reviewed Apr 4, 2023
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseSample.java Outdated
rajatbhatta
rajatbhatta reviewed Apr 4, 2023
View reviewed changes
Comment thread samples/snippets/src/test/java/com/example/spanner/UpdateDatabaseSampleIT.java Outdated
rajatbhatta
rajatbhatta approved these changes Apr 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from a few minor nits.

Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseSample.java Outdated
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseSample.java
Comment thread samples/snippets/src/main/java/com/example/spanner/UpdateDatabaseSample.java
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team May 16, 2023 14:37
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@rajatbhatta rajatbhatta added the automerge Merge the pull request once unit tests and other checks pass. label May 16, 2023
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 6aadc2f into googleapis:main May 16, 2023
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anguillanneuf anguillanneuf

Labels

api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aayushimalik @rajatbhatta @anguillanneuf @yoshi-kokoro