Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

test: fine grained access control for Postgres dialect.#2341

Merged
gcf-merge-on-green[bot] merged 6 commits intogoogleapis:mainfrom
arpan14:fgac-pr
Jun 6, 2023
Merged

test: fine grained access control for Postgres dialect.#2341
gcf-merge-on-green[bot] merged 6 commits intogoogleapis:mainfrom
arpan14:fgac-pr

Conversation

@arpan14
Copy link
Copy Markdown
Contributor

@arpan14 arpan14 commented Mar 21, 2023 •
edited
Loading

  • Parameterised the existing tests to support additional dialect POSTGRESQL.

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 21, 2023
@arpan14 arpan14 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 21, 2023
@arpan14 arpan14 marked this pull request as ready for review April 17, 2023 15:23
@arpan14 arpan14 requested a review from a team April 17, 2023 15:23
asthamohta
asthamohta approved these changes Apr 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asthamohta asthamohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rajatbhatta
rajatbhatta approved these changes Apr 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from a few suggestions.

Comment thread ...le-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseRolePermissionTest.java
Comment thread ...le-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseRolePermissionTest.java Outdated
Comment thread ...le-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseRolePermissionTest.java Outdated
arpan14 and others added 2 commits June 6, 2023 11:06
@arpan14 @rajatbhatta
Update google-cloud-spanner/src/test/java/com/google/cloud/spanner/it…
459916b 
…/ITDatabaseRolePermissionTest.java

Co-authored-by: Rajat Bhatta <[email protected]>
@arpan14 @rajatbhatta
Update google-cloud-spanner/src/test/java/com/google/cloud/spanner/it…
fe1960a 
…/ITDatabaseRolePermissionTest.java

Co-authored-by: Rajat Bhatta <[email protected]>
@arpan14 arpan14 added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 6, 2023
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team June 6, 2023 09:02
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-merge-on-green gcf-merge-on-green Bot merged commit ee72615 into googleapis:main Jun 6, 2023
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@asthamohta asthamohta asthamohta approved these changes

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arpan14 @asthamohta @rajatbhatta