This repository was archived by the owner on Apr 7, 2026. It is now read-only.
feat: Leader Aware Routing#2214
Merged
rajatbhatta merged 13 commits intogoogleapis:mainfrom Apr 28, 2023
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
Bot
added
size: l
yifanzyifanz
changed the title
x-goog-spanner-route-to-leader header to Spanner RPC contexts f…x-goog-spanner-route-to-leader header to Spanner RPC contexts f…
…exts for RW/PDML transactions. The header is added to support leader-aware-routing feature, which aims at reducing cross-regional latency for RW/PDML transactions in a multi-region instance.
…re routing feature
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
suggested changes
Jan 25, 2023
yifanzyifanz
requested review from
rajatbhatta
and removed request for
rajatbhatta
olavloite
approved these changes
Jan 27, 2023
Collaborator
olavloite
left a comment
olavloite
left a comment
There was a problem hiding this comment.
LGTM, with a couple of nits.
Tip: You could add an extra verification to this test to verify that the header is really sent to Cloud Spanner:
| @@ -275,7 +275,7 @@ public AsyncTransactionManagerImpl transactionManagerAsync(TransactionOption... | |||
| @Override | |||
| public void prepareReadWriteTransaction() { | |||
Collaborator
There was a problem hiding this comment.
Not relevant for this PR, but note to self/other readers: This seems like a method that can be cleaned up. I don't think it is in use anymore. @rajatbhatta Would you mind taking a look at that?
Contributor
There was a problem hiding this comment.
Sure, I'll take a look. @yifanzyifanz: Please keep this comment unresolved for the time being.
rajatbhatta
approved these changes
Jan 31, 2023
Contributor
There was a problem hiding this comment.
LGTM (apart from one of my pending comments and nits from @olavloite)
| @@ -275,7 +275,7 @@ public AsyncTransactionManagerImpl transactionManagerAsync(TransactionOption... | |||
| @Override | |||
| public void prepareReadWriteTransaction() { | |||
Contributor
There was a problem hiding this comment.
Sure, I'll take a look. @yifanzyifanz: Please keep this comment unresolved for the time being.
…eader header exists for RW transactions and does not exist for RO transactions or when the leader aware routing feature is disabled.
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
rajatbhatta
added
the
do not merge
rajatbhatta
suggested changes
Feb 6, 2023
Contributor
rajatbhatta
left a comment
rajatbhatta
left a comment
There was a problem hiding this comment.
Adding "Request changes" to prevent accidental merge of this PR. Note that the changes still look good to me.
rajatbhatta
removed
the
do not merge
rajatbhatta
approved these changes
Apr 27, 2023
rajatbhatta
changed the title
x-goog-spanner-route-to-leader header to Spanner RPC contexts f…
Contributor
|
Changing the Title to make it consistent across clients. |
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
x-goog-spanner-route-to-leaderheader to Spanner RPC contexts for RW/PDML transactions.The header is added to support leader-aware-routing feature, which aims at reducing cross-regional latency for RW/PDML transactions in a multi-region instance.
This feature is off by default and can be enabled by enabling Leader Aware Routing while creating Spanner object.
Spanner spanner = SpannerOptions.newBuilder().enableLeaderAwareRouting().build().getService();