This repository was archived by the owner on Apr 7, 2026. It is now read-only.
chore: make Partition class getters public#2195
Merged
gcf-merge-on-green[bot] merged 6 commits intomainfrom Dec 13, 2022
Merged
chore: make Partition class getters public#2195gcf-merge-on-green[bot] merged 6 commits intomainfrom
gcf-merge-on-green[bot] merged 6 commits intomainfrom
Conversation
Make getters in Partition class public so that they can be accessed outside com.google.cloud.spanner package.
product-auto-label
Bot
added
size: s
olavloite
approved these changes
Dec 13, 2022
Collaborator
olavloite
left a comment
olavloite
left a comment
There was a problem hiding this comment.
LGTM, with a small nit on the getColumns() method.
Why do we need to make this public?
Contributor
Author
I only need getPartitionToken to be made public for some Google-internal tests to be run. There are some asserts which need to check for the partitionToken, and with default access specifier, it was not accessible outside com.google.cloud.spanner package. I'll probably have the rest of the getters as default and will make them public in the future if need be. |
product-auto-label
Bot
added
size: xs
rajatbhatta
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
This was referenced Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make getters in Partition class public so that they can be accessed outside com.google.cloud.spanner package.