Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

test: mock Spanner did not create jsonb parameters#2182

Merged
olavloite merged 1 commit intomainfrom
use-jsonb-in-mock-server
Dec 5, 2022
Merged

test: mock Spanner did not create jsonb parameters#2182
olavloite merged 1 commit intomainfrom
use-jsonb-in-mock-server

Conversation

@olavloite
Copy link
Copy Markdown
Collaborator

The mock Spanner server that is used for testing did not create statements with PG JSONB typed parameters. Instead, all parameters with TypeCode JSON would create statements with parameters of type JSON, regardless of any TypeAnnotationCode.

The mock Spanner server that is used for testing did not create statements
with PG JSONB typed parameters. Instead, all parameters with TypeCode JSON
would create statements with parameters of type JSON, regardless of any
TypeAnnotationCode.
@olavloite olavloite added the type: cleanup An internal cleanup or hygiene concern. label Dec 4, 2022
@olavloite olavloite requested a review from a team December 4, 2022 11:26
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 4, 2022
@olavloite olavloite requested a review from rajatbhatta December 4, 2022 17:59
Copy link
Copy Markdown
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite merged commit d82115d into main Dec 5, 2022
@olavloite olavloite deleted the use-jsonb-in-mock-server branch December 5, 2022 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants