This repository was archived by the owner on Apr 7, 2026. It is now read-only.
feat(spanner): add samples for fine grained access control#2172
Merged
feat(spanner): add samples for fine grained access control#2172
Conversation
product-auto-label
Bot
added
size: l
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
rahul2393
requested review from
ansh0l and
rajatbhatta
and removed request for
ansh0l
Contributor
|
@rahul2393: I think we should add integration tests for the samples similar to https://github.com/googleapis/java-spanner/pull/2007/files#diff-cbbf8310726971f9d351d2727d761558fcea52286bd9b86628e83e763f8b63f0. Please add |
rajatbhatta
reviewed
Nov 28, 2022
rajatbhatta
reviewed
Dec 5, 2022
rajatbhatta
reviewed
Dec 5, 2022
rahul2393
force-pushed
the
add-fgac-samples
branch
from
077afcc to
d4ad45f
Compare
rajatbhatta
approved these changes
Dec 15, 2022
Contributor
rajatbhatta
left a comment
rajatbhatta
left a comment
There was a problem hiding this comment.
Lgtm in general, just a couple of comments. You can merge it once the tests pass post those changes.
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.
EnableFineGrainedAccess sample requires service account to work, so skipping integration tests for the same.