This repository was archived by the owner on Apr 7, 2026. It is now read-only.
refactor: Removing duplicated code to handle array values#2143
Merged
gauravpurohit06 merged 4 commits intogoogleapis:mainfrom Dec 7, 2022
Merged
refactor: Removing duplicated code to handle array values#2143gauravpurohit06 merged 4 commits intogoogleapis:mainfrom
gauravpurohit06 merged 4 commits intogoogleapis:mainfrom
Conversation
The same deserialization logic for data types have been duplicated at multiple places which is prone to error.
product-auto-label
Bot
added
size: m
gauravpurohit06
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
olavloite
reviewed
Nov 7, 2022
Collaborator
olavloite
left a comment
olavloite
left a comment
There was a problem hiding this comment.
Brilliant find. I have a couple of questions whether we could make this even more efficient, now that we are looking into this. Would you mind taking a look at that?
gauravpurohit06
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
rajatbhatta
approved these changes
Dec 7, 2022
Contributor
rajatbhatta
left a comment
rajatbhatta
left a comment
There was a problem hiding this comment.
LGTM. Thanks for working on this enhancement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Business logic to decode data types enclosed in an array is duplicated at multiple places which is prone to error and bugs.