Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

feat: add support for Optimistic Concurrency Control#2142

Merged
rajatbhatta merged 10 commits intogoogleapis:mainfrom
ko3a4ok:main
Jan 17, 2023
Merged

feat: add support for Optimistic Concurrency Control#2142
rajatbhatta merged 10 commits intogoogleapis:mainfrom
ko3a4ok:main

Conversation

@ko3a4ok
Copy link
Copy Markdown
Contributor

@ko3a4ok ko3a4ok commented Nov 3, 2022 •
edited by rajatbhatta
Loading

Initially, it was proposed in #1957

BEGIN_COMMIT_OVERRIDE
chore: add support for Optimistic Concurrency Control
END_COMMIT_OVERRIDE

@ko3a4ok ko3a4ok requested a review from a team November 3, 2022 00:49
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Nov 3, 2022
@ansh0l ansh0l added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 9, 2022
@rajatbhatta rajatbhatta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 15, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team November 23, 2022 07:20
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
rajatbhatta
rajatbhatta reviewed Jan 12, 2023
View reviewed changes
Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java Outdated
Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java Outdated
Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java Outdated
Comment thread ...-spanner/src/test/java/com/google/cloud/spanner/ReadWriteTransactionWithInlineBeginTest.java
Comment thread ...-spanner/src/test/java/com/google/cloud/spanner/ReadWriteTransactionWithInlineBeginTest.java
Comment thread ...-spanner/src/test/java/com/google/cloud/spanner/ReadWriteTransactionWithInlineBeginTest.java
rajatbhatta
rajatbhatta approved these changes Jan 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for working on this, @ko3a4ok !

@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2023
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2023
@rajatbhatta rajatbhatta merged commit b3fc7c4 into googleapis:main Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ko3a4ok @rajatbhatta @ansh0l @yoshi-kokoro